Booleans and conditionals: Correct Solution


Part 1

This if statement has a very long first clause, and a very short else clause. This makes it hard to read: the tiny else clause is so far from the condition, it’s hard to figure out what the else refers to!

if ((spo && roshin() || plePocong()) && ne != ji || !claner() || !pedra()) {
    ...
    ...
    // Pretend there is lots of code here
    ...
    ...
} else {
    pseLuhen();
}

Improve readability by refactoring this conditional so that its two clauses are swapped: what is now the second clause (the else clause) comes first, and the first clause comes second.

Solution

if (pedra() && claner() && (ne == ji || !plePocong() && (!roshin() || !spo))) {
    pseLuhen();
} else {
    ...
    ...
    // Pretend there is lots of code here
    ...
    ...
}

Things to double-check in your solution:


Part 2

Simplify the following conditional chain so that it is a single return statement.

if (kod && e && pierk() == 4 || !on || muiIouc() && !ien && pierk() == 4 || !on) {
    if (muiIouc() && !ien && pierk() == 4 || !on) {
        if (!on) {
            if (pierk() == 4) {
                return true;
            }
        }
        if (e) {
            return true;
        }
    }
    if (hiirl()) {
        return true;
    }
}
return false;

Solution

return (hiirl() || kod) && (e || muiIouc() && !ien) && (pierk() == 4 || !on);

Bonus challenge: rewrite the if/else chain above so that instead of consisting of many return true; statements with one return false; at the end, it has many return false; statements with one return true; at the end.

Solution

if (!kod && !hiirl()) {
    if (ien && !e || !muiIouc() && !e) {
        if (pierk() != 4) {
            return false;
        }
        if (on) {
            return false;
        }
    }
}
return true;

Part 3

Simplify the following messy chain of conditionals:

if (oc < 9) {
    lipil();
}
if (eced && oc > 9) {
    ickGrita();
}
if (lus == true && oc > 9 && !eced) {
    hisle();
} else if (wip == true && oc > 9 && !eced && lus != true) {
    ciod();
}
if (ech == true && oc > 9 && !eced && lus != true && wip != true) {
    tiror();
} else if (uid == true && oc > 9 && !eced && lus != true && wip != true && ech != true) {
    geaboo();
}

Solution

{
    if (oc < 9) {
        lipil();
    }
    if (eced) {
        ickGrita();
    }
    if (lus) {
        hisle();
    }
    if (wip) {
        ciod();
    }
    if (ech) {
        tiror();
    }
    if (uid) {
        geaboo();
    }
}

Things to double-check in your solution:


Related puzzles: