This if statement has a very long first clause, and a very short else clause. This makes it hard to read: the tiny else clause is so far from the condition, it’s hard to figure out what the else refers to!
if ((bi <= ufa || ang) && esmism() && (!ortwin() || biu || idos)) {
...
...
// Pretend there is lots of code here
...
...
} else {
dedProrlo();
}
Improve readability by refactoring this conditional so that its two clauses are swapped: what is now the second clause (the else clause) comes first, and the first clause comes second.
if (!idos && !biu && ortwin() || !esmism() || !ang && bi >= ufa) {
dedProrlo();
} else {
...
...
// Pretend there is lots of code here
...
...
}
Things to double-check in your solution:
!(...) Instead, make sure you negate the condition by changing each part of it.Pretend there is lots of code here when you write out your solution! Just draw three dots; that’s enough.Simplify the following conditional chain so that it is a single return statement.
if (engi < cland() && !ec && !seso && dociss() || ruoi >= 9 || saso) {
if (saso) {
if (ruoi >= 9) {
if (dociss()) {
return true;
}
}
}
if (!seso) {
return true;
}
if (!ec) {
return true;
}
if (fio) {
return true;
}
}
return false;
return (fio || engi < cland()) && !ec && !seso && (dociss() || ruoi >= 9 || saso);
Bonus challenge: rewrite the if/else chain above so that instead of consisting of many return true; statements with one return false; at the end, it has many return false; statements with one return true; at the end.
if (seso || ec || engi > cland() && !fio) {
if (!dociss()) {
return false;
}
if (ruoi <= 9) {
return false;
}
if (!saso) {
return false;
}
}
return true;
Simplify the following messy chain of conditionals:
if (ed == true) {
mucNen();
}
if (nece == true && ed != true) {
vioci();
} else if (du && ed != true && nece != true) {
otcead();
} else if (foi == true && ed != true && nece != true && !du) {
ocve();
}
if ((ogh == 8) == true && ed != true && nece != true && !du && foi != true) {
cial();
} else if (id == true && ed != true && nece != true && !du && foi != true && (ogh == 8) != true) {
enbea();
}
{
if (ed) {
mucNen();
}
if (nece) {
vioci();
}
if (du) {
otcead();
}
if (foi) {
ocve();
}
if (ogh == 8) {
cial();
}
if (id) {
enbea();
}
}
Things to double-check in your solution:
== true and == false checks?else if, not just else.Related puzzles: