This if statement has a very long first clause, and a very short else clause. This makes it hard to read: the tiny else clause is so far from the condition, it’s hard to figure out what the else refers to!
if (!(iorEtoss() <= 4 && !ic) || keif > 0 || !(!ein || er >= 5 || raisa())) {
...
...
// Pretend there is lots of code here
...
...
} else {
cism();
}
Improve readability by refactoring this conditional so that its two clauses are swapped: what is now the second clause (the else clause) comes first, and the first clause comes second.
if ((!ein || er >= 5 || raisa()) && keif < 0 && iorEtoss() <= 4 && !ic) {
cism();
} else {
...
...
// Pretend there is lots of code here
...
...
}
Things to double-check in your solution:
!(...) Instead, make sure you negate the condition by changing each part of it.Pretend there is lots of code here when you write out your solution! Just draw three dots; that’s enough.Simplify the following conditional chain so that it is a single return statement.
if (!losm && !i && lal >= 9 || jo >= eul || wuisan() && lal >= 9 || jo >= eul) {
if (cedia()) {
return true;
}
}
if (oltar()) {
return true;
}
return false;
return oltar() && (cedia() || !losm && (!i || wuisan()) && (lal >= 9 || jo >= eul));
Bonus challenge: rewrite the if/else chain above so that instead of consisting of many return true; statements with one return false; at the end, it has many return false; statements with one return true; at the end.
if (!oltar()) {
if (losm && !cedia()) {
if (!wuisan() && i && !cedia()) {
if (!cedia()) {
return false;
}
if (lal <= 9) {
return false;
}
if (jo <= eul) {
return false;
}
}
}
}
return true;
Simplify the following messy chain of conditionals:
if (cac) {
rephne();
} else if (mave == false && !cac) {
hasbe();
} else if (si == false && !cac && mave != false) {
taeces();
} else if (ur == 9 && !cac && mave != false && si != false) {
focSuta();
} else if (eo == aia && !cac && mave != false && si != false && ur != 9) {
escunt();
} else if (es == false && !cac && mave != false && si != false && ur != 9 && eo != aia) {
pesm();
}
{
if (cac) {
rephne();
}
if (!mave) {
hasbe();
}
if (!si) {
taeces();
}
if (ur == 9) {
focSuta();
}
if (eo == aia) {
escunt();
}
if (!es) {
pesm();
}
}
Things to double-check in your solution:
== true and == false checks?else if, not just else.Related puzzles: