This if statement has a very long first clause, and a very short else clause. This makes it hard to read: the tiny else clause is so far from the condition, it’s hard to figure out what the else refers to!
if (!((osm == 5 || !(ilun || ipiSochlu())) && geu == 0) || prir() || channa()) {
...
...
// Pretend there is lots of code here
...
...
} else {
hacho();
}
Improve readability by refactoring this conditional so that its two clauses are swapped: what is now the second clause (the else clause) comes first, and the first clause comes second.
if (!channa() && !prir() && (osm == 5 || !(ilun || ipiSochlu())) && geu == 0) {
hacho();
} else {
...
...
// Pretend there is lots of code here
...
...
}
Things to double-check in your solution:
!(...) Instead, make sure you negate the condition by changing each part of it.Pretend there is lots of code here when you write out your solution! Just draw three dots; that’s enough.Simplify the following conditional chain so that it is a single return statement.
if (lia && spism() != 2 || a == ocra || ial && spism() != 2 || a == ocra) {
if (issPidam()) {
if (psed() != edmeal()) {
return true;
}
}
if (isme < 2) {
return true;
}
}
return false;
return isme < 2 && (psed() != edmeal() || issPidam()) || (lia || ial) && (spism() != 2 || a == ocra);
Bonus challenge: rewrite the if/else chain above so that instead of consisting of many return true; statements with one return false; at the end, it has many return false; statements with one return true; at the end.
if (!ial && !lia && !issPidam() && psed() == edmeal() || isme > 2) {
if (isme > 2) {
if (psed() == edmeal()) {
return false;
}
if (!issPidam()) {
return false;
}
}
if (spism() == 2) {
return false;
}
if (a != ocra) {
return false;
}
}
return true;
Simplify the following messy chain of conditionals:
if (or == 0 == true) {
skuSoni();
}
if (eti && or == 0 != true) {
thudid();
}
if (mi == false && or == 0 != true && !eti) {
cadda();
} else if ((pri == ur) == true && or == 0 != true && !eti && mi != false) {
biarfu();
}
if (ju == false && or == 0 != true && !eti && mi != false && (pri == ur) != true) {
deng();
}
if (or == 0 != true && !eti && mi != false && (pri == ur) != true && ju != false) {
sucBasse();
}
{
if (or == 0) {
skuSoni();
}
if (eti) {
thudid();
}
if (!mi) {
cadda();
}
if (pri == ur) {
biarfu();
}
if (!ju) {
deng();
}
sucBasse();
}
Things to double-check in your solution:
== true and == false checks?else, no final if.Related puzzles: