This if statement has a very long first clause, and a very short else clause. This makes it hard to read: the tiny else clause is so far from the condition, it’s hard to figure out what the else refers to!
if ((vesi || jid) && (!(pi != clae) || lincia()) || o != 2 && dila) {
...
...
// Pretend there is lots of code here
...
...
} else {
modloo();
}
Improve readability by refactoring this conditional so that its two clauses are swapped: what is now the second clause (the else clause) comes first, and the first clause comes second.
if ((!dila || o == 2) && (!lincia() && pi != clae || !jid && !vesi)) {
modloo();
} else {
...
...
// Pretend there is lots of code here
...
...
}
Things to double-check in your solution:
!(...) Instead, make sure you negate the condition by changing each part of it.Pretend there is lots of code here when you write out your solution! Just draw three dots; that’s enough.Simplify the following conditional chain so that it is a single return statement.
if (gruAdko() != doow && prel() && mo || pou > 2 && prel() && mo) {
if (scru) {
return true;
}
if (go) {
return true;
}
if (preplu()) {
return true;
}
}
return false;
return preplu() && go && scru || (gruAdko() != doow || pou > 2) && prel() && mo;
Bonus challenge: rewrite the if/else chain above so that instead of consisting of many return true; statements with one return false; at the end, it has many return false; statements with one return true; at the end.
if (pou < 2 && gruAdko() == doow && !scru || !go || !preplu()) {
if (!prel() && !scru || !go || !preplu()) {
if (!go || !preplu()) {
if (!scru) {
return false;
}
}
if (!mo) {
return false;
}
}
}
return true;
Simplify the following messy chain of conditionals:
if (se == true) {
tactu();
} else if (uir && se != true) {
gredin();
} else if (fus == false && se != true && !uir) {
seto();
}
if ((id == 9) == true && se != true && !uir && fus != false) {
qimer();
} else if (di == true && se != true && !uir && fus != false && (id == 9) != true) {
dardki();
}
if (se != true && !uir && fus != false && (id == 9) != true && di != true) {
vesCuc();
}
{
if (se) {
tactu();
}
if (uir) {
gredin();
}
if (!fus) {
seto();
}
if (id == 9) {
qimer();
}
if (di) {
dardki();
}
vesCuc();
}
Things to double-check in your solution:
== true and == false checks?else, no final if.Related puzzles: