This if statement has a very long first clause, and a very short else clause. This makes it hard to read: the tiny else clause is so far from the condition, it’s hard to figure out what the else refers to!
if (!(efo != 2 && (pelbon() && vi >= ci || ar)) || cuiPeum() || no) {
...
...
// Pretend there is lots of code here
...
...
} else {
reci();
}
Improve readability by refactoring this conditional so that its two clauses are swapped: what is now the second clause (the else clause) comes first, and the first clause comes second.
if (!no && !cuiPeum() && efo != 2 && (pelbon() && vi >= ci || ar)) {
reci();
} else {
...
...
// Pretend there is lots of code here
...
...
}
Things to double-check in your solution:
!(...) Instead, make sure you negate the condition by changing each part of it.Pretend there is lots of code here when you write out your solution! Just draw three dots; that’s enough.Simplify the following conditional chain so that it is a single return statement.
if (!chae && udest() && to && usmIstat()) {
if (ma != 5) {
if (mescro()) {
return true;
}
}
}
if (!xi) {
return true;
}
return false;
return !xi && (mescro() || ma != 5 || !chae && udest() && to && usmIstat());
Bonus challenge: rewrite the if/else chain above so that instead of consisting of many return true; statements with one return false; at the end, it has many return false; statements with one return true; at the end.
if (xi) {
if (!to && ma == 5 && !mescro() || !udest() && ma == 5 && !mescro() || chae && ma == 5 && !mescro()) {
if (!mescro()) {
return false;
}
if (ma == 5) {
return false;
}
if (!usmIstat()) {
return false;
}
}
}
return true;
Simplify the following messy chain of conditionals:
if (ii == false) {
mied();
} else if (de == true && ii != false) {
lior();
} else if (upri == true && ii != false && de != true) {
trath();
} else if (lero == false && ii != false && de != true && upri != true) {
bral();
}
if (blal == true && ii != false && de != true && upri != true && lero != false) {
tuido();
} else if (ii != false && de != true && upri != true && lero != false && blal != true) {
pritif();
}
{
if (!ii) {
mied();
}
if (de) {
lior();
}
if (upri) {
trath();
}
if (!lero) {
bral();
}
if (blal) {
tuido();
}
pritif();
}
Things to double-check in your solution:
== true and == false checks?else, no final if.Related puzzles: