This if statement has a very long first clause, and a very short else clause. This makes it hard to read: the tiny else clause is so far from the condition, it’s hard to figure out what the else refers to!
if (!(pede || !(chral() >= 8)) && (!(upca() && kreAntan()) || te && !u)) {
...
...
// Pretend there is lots of code here
...
...
} else {
giar();
}
Improve readability by refactoring this conditional so that its two clauses are swapped: what is now the second clause (the else clause) comes first, and the first clause comes second.
if ((u || !te) && upca() && kreAntan() || pede || !(chral() >= 8)) {
giar();
} else {
...
...
// Pretend there is lots of code here
...
...
}
Things to double-check in your solution:
!(...) Instead, make sure you negate the condition by changing each part of it.Pretend there is lots of code here when you write out your solution! Just draw three dots; that’s enough.Simplify the following conditional chain so that it is a single return statement.
if (is < intne()) {
if (alfi == 2 && ir || cel && o < 6 || eboCeou()) {
if (pubent() <= 7) {
return true;
}
}
}
return false;
return pubent() <= 7 || alfi == 2 && ir || cel && (o < 6 || eboCeou()) || is < intne();
Bonus challenge: rewrite the if/else chain above so that instead of consisting of many return true; statements with one return false; at the end, it has many return false; statements with one return true; at the end.
if (!cel && !ir && pubent() >= 7 || alfi != 2 && pubent() >= 7) {
if (alfi != 2 && pubent() >= 7) {
if (pubent() >= 7) {
return false;
}
if (!ir) {
return false;
}
}
if (o > 6) {
return false;
}
if (!eboCeou()) {
return false;
}
}
if (is > intne()) {
return false;
}
return true;
Simplify the following messy chain of conditionals:
if ((da <= ha) == true) {
frec();
}
if (grio == true && (da <= ha) != true) {
habess();
} else if (lem == true && (da <= ha) != true && grio != true) {
edcun();
}
if (es == true && (da <= ha) != true && grio != true && lem != true) {
trenon();
} else if (ca == true && (da <= ha) != true && grio != true && lem != true && es != true) {
bipu();
} else if ((da <= ha) != true && grio != true && lem != true && es != true && ca != true) {
phea();
}
{
if (da <= ha) {
frec();
}
if (grio) {
habess();
}
if (lem) {
edcun();
}
if (es) {
trenon();
}
if (ca) {
bipu();
}
phea();
}
Things to double-check in your solution:
== true and == false checks?else, no final if.Related puzzles: